Skip to content

Conversation

skl
Copy link
Collaborator

@skl skl commented Nov 7, 2024

This Pint lint check still fails, even when I explicitly join on certain labels as in this PR. I think this might be a bug in Pint.

EDIT - fixed in https://github.com/cloudflare/pint/releases/tag/v0.71.0

I would like to be able to use without to cater for custom external labels that users might have configured on their metrics, so this seems like the lint check is a little too strict IMO.

Fixes #985

Rendered alert was tested manually on a fleet of clusters:

sum(increase(container_cpu_cfs_throttled_periods_total{container!="", job!="", }[5m])) without (id, metrics_path, name, image, endpoint, job, node)
  / on (cluster, namespace, pod, container, instance) group_left
sum(increase(container_cpu_cfs_periods_total{job!="", }[5m])) without (id, metrics_path, name, image, endpoint, job, node)
  > ( 25 / 100 )
Screenshot 2025-03-14 at 15 02 39

@skl skl added the bug Something isn't working label Nov 7, 2024
@skl skl self-assigned this Nov 7, 2024
@skl skl requested a review from povilasv as a code owner November 7, 2024 20:03
Copy link

github-actions bot commented Dec 8, 2024

This PR has been automatically marked as stale because it has not
had any activity in the past 30 days.

The next time this stale check runs, the stale label will be
removed if there is new activity. The issue will be closed in 7
days if there is no new activity.

Thank you for your contributions!

@skl
Copy link
Collaborator Author

skl commented Mar 14, 2025

Should be fixed in this pint release:

@skl
Copy link
Collaborator Author

skl commented Mar 14, 2025

This PR will also revert the previous workaround:

@skl skl merged commit 70e362b into master Mar 14, 2025
18 checks passed
@skl skl deleted the skl/fix-985 branch March 27, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working keepalive Use to prevent automatic closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Pint lint failure on CPUThrottlingHigh alert

3 participants